Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(java17): build JRE 17 images, run tests with JRE 17 #1342

Merged
merged 2 commits into from Nov 28, 2023
Merged

feat(java17): build JRE 17 images, run tests with JRE 17 #1342

merged 2 commits into from Nov 28, 2023

Conversation

mattgogerly
Copy link
Member

@mattgogerly mattgogerly commented Sep 26, 2023 •
edited by dbyron-sf

Number 3 on our Java 17 adventure.

See also spinnaker/front50#1274, spinnaker/igor#1143

@mattgogerly mattgogerly force-pushed the feat/jre17 branch 3 times, most recently from dac5655 to 67ccaac Compare September 26, 2023 17:53
@mattgogerly
Copy link
Member Author

I have no idea why this test is randomly failing now.

@dbyron-sf
Copy link
Contributor

I have no idea why this test is randomly failing now.

Some word wrapping behavior is different with java 17 maybe?

@mattgogerly
Copy link
Member Author

mattgogerly commented Sep 28, 2023 •
edited

I have no idea why this test is randomly failing now.

Some word wrapping behavior is different with java 17 maybe?

Looks like it's this, introduced in Java 13. stripIndent() didn't exist as a Java method in 11, and came from Groovy instead. Now it does exist as of 13.

For each non-blank line, min leading white space characters are removed, and any trailing white space characters are removed. Blank lines are replaced with the empty string.

Gotta love removing trailing whitespace in a method called stripIndent() 😅

@mattgogerly
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

update

✅ Branch has been successfully updated

@mattgogerly
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2023

update

✅ Branch has been successfully updated

@dbyron-sf
Copy link
Contributor

LGTM, but there's an error building the slim container image:

#9 [linux/amd64 2/4] RUN adduser --system --uid 10111 --group spinnaker
#9 0.115 adduser: group 'spinnaker' does not exist
#9 ERROR: process "/bin/sh -c adduser --system --uid 10111 --group spinnaker" did not complete successfully: exit code: 6

@mattgogerly mattgogerly mentioned this pull request Oct 3, 2023
Closed
@mattgogerly
Copy link
Member Author

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2023

update

✅ Branch has been successfully updated

@mattgogerly mattgogerly added the ready to merge Approved and ready for merge label Nov 28, 2023
@mergify mergify bot added the auto merged label Nov 28, 2023
@mergify mergify bot merged commit 4a17a5c into master Nov 28, 2023
5 checks passed
@mattgogerly mattgogerly deleted the feat/jre17 branch November 28, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.33
Projects
None yet
Milestone
No milestone
3 participants
@mattgogerly @dbyron-sf @spinnakerbot