Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cron): fix to not fire the same cron job on multiple instances #592

Merged
merged 1 commit into from
Jul 2, 2019
Merged

fix(cron): fix to not fire the same cron job on multiple instances #592

merged 1 commit into from
Jul 2, 2019

Conversation

marchello2000
Copy link
Contributor

it seems that read-committed on mysql doesn't have strong enough locking for
quartz to ensure only one clustered instance picks up a given cron trigger.
Documentation suggests to set acquireTriggersWithinLock to true

(also see quartz-scheduler/quartz#107)

@ajordens
Copy link
Contributor

ajordens commented Jul 2, 2019 •
edited
Loading 

Whether or not the acquisition of next triggers to fire should occur within an explicit database lock. This was once necessary (in previous versions of Quartz) to avoid dead-locks with particular databases, but is no longer considered necessary, hence the default value is “false”.

That seems weird?

@ajordens
Copy link
Contributor

ajordens commented Jul 2, 2019 •
edited
Loading

Ahh just reading that linked quartz-scheduler issue, this sounds alright to me (not really an expert in this 🤷‍♀but don't have a strong argument against it)

@marchello2000
Copy link
Contributor Author

yeah, I am at a bit of a loss myself.. but most signs point to this helping - hard to test locally

@marchello2000
fix(cron): fix to not fire the same cron job on multiple instances
59603cb 
it seems that `read-committed` on mysql doesn't have strong enough locking for
quartz to ensure only one clustered instance picks up a given cron trigger.
[Documentation](http://www.quartz-scheduler.org/documentation/quartz-2.1.7/configuration/ConfigJobStoreTX.html) suggests to set `acquireTriggersWithinLock` to `true`
@marchello2000 marchello2000 merged commit 1708ec0 into spinnaker:master Jul 2, 2019
@marchello2000 marchello2000 deleted the mark/spin-4869 branch March 11, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajordens ajordens Awaiting requested review from ajordens

Assignees
No one assigned
Labels
target-release/1.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marchello2000 @ajordens @spinnakerbot