Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): revert mergify config #675

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Conversation

plumpy
Copy link
Member

@plumpy plumpy commented Oct 16, 2019

Reverts #673

I'm fairly certain this turns every reviewer into an approver. (Reviewers have the triage permission, which allows them to add labels.)

Merging this without a review, since you did too 😉

@plumpy plumpy added the ready to merge Approved and ready for merge label Oct 16, 2019
@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@plumpy plumpy changed the title Revert "chore(github): test out mergify config" chore(github): revert mergify config Oct 16, 2019
@plumpy plumpy merged commit 2c29c10 into master Oct 16, 2019
@marchello2000
Copy link
Contributor

@plumpy thanks for reverting this and sorry about this - my understanding from @robzienert was that only approvers can add labels. I will follow up with him on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Approved and ready for merge target-release/1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants