fix(stats): Deregister the telemetry circuit breaker from the health indicator #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisjimenez
approved these changes
Nov 21, 2019
ttomsu
pushed a commit
to ttomsu/echo
that referenced
this pull request
Dec 9, 2019
ttomsu
pushed a commit
that referenced
this pull request
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in October, the telemetry endpoint went down, causing our nightly tests to start failing. The root cause was that the resiliance4j circuit breaker library was hooked up to the Spring Boot health endpoint, so when the breaker was tripped (yay that this part worked as intended), it caused Echo's
/healthendpoint to start returning 503s, and thus traffic to it was halted in a Kubernetes environment.The fix is to not register the circuit breaker with the health endpoint. I added a system test to confirm this (heavy handed, yes, but I don't know how else to test this dependency) and for good measure, I added a unit test that throws various Retrofit errors.
tag: spinnaker/spinnaker#5144