feat(extension): Add flattenEvent parsing to RestEventParser and convert Groovy to Java in echo-rest #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsie
force-pushed
the
parse-flat-convert-groovy-java
branch
3 times, most recently
from
8373004
to
db3fc6f
Compare
cfieber
approved these changes
Nov 25, 2019
echo-rest/src/main/java/com/netflix/spinnaker/echo/config/RestConfig.java
Outdated
Show resolved
Hide resolved
echo-rest/src/main/java/com/netflix/spinnaker/echo/events/RestEventListener.java
Outdated
Show resolved
Hide resolved
…ert Groovy to Java in echo-rest
jonsie
force-pushed
the
parse-flat-convert-groovy-java
branch
from
db3fc6f
to
4c2a962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to add the
flattenEventtoRestEventParser(following up on @cfieber suggestion to support that feature from last week) and as I was doing that I started converting some things to Java and then I ended up converting it all to Java.I could break this PR up into multiple PRs if we feel that's better to review.