Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove newline in Orca notification description #751

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Remove newline in Orca notification description #751

merged 2 commits into from
Jan 21, 2020

Conversation

KeisukeYamashita
Copy link
Member

What

  • Remove newline in the list of Orca's description

Why

  • No need

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 816d2ed: fix(README): Remove newline in Orca notification description

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@cfieber cfieber added the ready to merge Approved and ready for merge label Jan 21, 2020
@mergify mergify bot merged commit 50d4d4e into spinnaker:master Jan 21, 2020
@mergify mergify bot added the auto merged label Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfieber cfieber cfieber approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.19
Projects
None yet
Milestone
No milestone
3 participants
@KeisukeYamashita @spinnakerbot @cfieber