Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove newline in Orca notification description #751

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Remove newline in Orca notification description #751

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd7dfe9
fix(doc): remove newline in Orca notification description
KeisukeYamashita Jan 20, 2020
f4cf968
Merge branch 'master' into fix-newline-in-doc
cfieber Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ The following high level diagram shows how events flow through `echo`:
5. `orca` sends events to `echo` when:
- a stage is starting/completed so `echo` can send notifications if any are defined on the stage
- a pipeline (or orchestration) is starting/completed so `echo` can send notification as above
- a manual judgement stage is reached - a notifcation from
- the user has clicked the page button on the application page
- a manual judgement stage is reached - a notifcation from the user has clicked the page button on the application page

6. `echo` uses external services (e.g. email/slack) to send notifications.
Notifications can either be a result of an event received by `echo` (e.g. stage completed which has a notification on completion), or a specific notification request from another service (e.g. orca will send a notifcation for Manual Judgement stage)
Expand Down