chore(java11): Compile with Java 11 (but targeting Java 8) #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plumpy
force-pushed
the
java11
branch
2 times, most recently
from
ad82373
to
55fcf84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually need
-PenableCrossCompilerPlugin=trueinbuild.ymlorrelease.yml(it's turned on already by the Nebula plugin since we're making a candidate build) but I thought it was worth adding for clarity.For the GitHub workflows, I didn't know a great way to test it, so I first read setup-java to determine how the
$PATHmanipulation works, then I tested it withpr.ymlby:Optional#stream()) and seeing the build fail (proving we're compiling against the Java 8 APIs)-PenableCrossCompilerPlugin=falseand watching the build succeed (proving we're using the Java 11javac)