fix(headers): Metadata requestHeaders lookup should be case insensitive #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 20, 2020
xavileon
approved these changes
Apr 20, 2020
marchello2000
approved these changes
Apr 20, 2020
|
@ezimanyi I assume this will need to be cherry picked into a release? |
|
Yup, for sure, in general feel free to just request the backport from mergify; I review the list of outstanding cherry-picks every day and merge them in. |
|
@Mergifyio backport release-1.19.x |
|
Command
|
Ah, very cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #790 I removed
HttpHeadersso thatecho-apicould be dependency free (basically, just Java) -- this is important for the ongoing extensibility / plugin work we are doing.However, I overlooked that
HttpHeadersbuilds a case insensitive map. This resolves that issue.Resolves: spinnaker/spinnaker#5645
Relates to: #840