fix(hooks): Fix github webhooks with secrets

[ferwguerra]

Issue:
The pipelines are no longer being triggered by Github webhooks if there is a secret required. Removing the secret allows them to function normally.

This issue was reported here.

Problem:
The headings are all lowercase, so they are now not found.
This previously worked because the org.springframework.http.HttpHeaders class was used but was replaced by java.util.Map, which is case sensitive. That change was made here.

[gregjones]

Is it possible they're lowercase when they arrive in our setup because of the load-balancer doing normalization? Maybe it makes sense to go back to using a case-insensitive lookup, or else normalize the case when the headers are copied?

[ferwguerra]

Is it possible they're lowercase when they arrive in our setup because of the load-balancer doing normalization? Maybe it makes sense to go back to using a case-insensitive lookup, or else normalize the case when the headers are copied?

The headers are mapped using org.springframework.http.HttpHeaders and that's the reason they are lowercase.
You can check running echo and sending this request:

curl --location --request POST 'http://localhost:8089/webhooks/git/github' \ --header 'User-Agent: GitHub-Hookshot/XXXXX' \ --header 'X-GitHub-Enterprise-Host: ${HOST}' \ --header 'X-GitHub-Enterprise-Version: 2.20.1' \ --header 'X-GitHub-Event: push' \ --header 'X-Hub-Signature: sha1=XXXXXXXXX' \ --header 'Content-Type: application/json' \ --data-raw '{ ... } }'

[xavileon]

@spinnaker/oss-approvers PTAL

[xavileon]

@spinnaker/oss-approvers any comment on this? thanks!

[ezimanyi]

@jonsie : Mind taking a look at this as it might be tangentially related to your PR #790. Thanks!

[wli66666]

any estimated time for merging this ? since this is a live bug.....

[sofam]

We are also hit by this.

[iiro]

We as well.

[jonsie]

@ferwguerra Thanks for the contribution, and sorry for introducing this bug (and also sorry for the delay here - missed this notification). I'm proposing an alternative fix here that addresses the underlying issue:

#863

[jonsie]

Addressed in #863