refactor(stats): add a simpler way to collect more data for stats #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't convert the ones that deal with the stats event content because I'm going to refactor how that works in a later commit.
Implementations can add their own data to the stats Event object. This allows us to pull data from a variety of sources without having to cram all that logic into TelemetryEventListener.
Some of the Groovy/Java code gets a little weirder because TelemetryConfigProps is in Kotlin, but after the next commit, all its clients will be in Kotlin, so it'll make more sense.
plumpy
force-pushed
the
refactor_event_service_take_2
branch
from
0d9b632
to
a366338
Compare
Now it is split between two different ExecutionDataProviders. For now, this is a little arbitrary, but I anticipate adding more complicated data providers that do RPCs and things, so this should make those future data providers much simpler to reason about and test.
plumpy
force-pushed
the
refactor_event_service_take_2
branch
from
a366338
to
21869bc
Compare
ezimanyi
reviewed
Jun 18, 2020
echo-telemetry/src/main/java/com/netflix/spinnaker/echo/config/TelemetryConfig.kt
Outdated
Show resolved
Hide resolved
ezimanyi
approved these changes
Jun 18, 2020
echo-telemetry/src/main/java/com/netflix/spinnaker/echo/telemetry/ExecutionDataProvider.kt
Show resolved
Hide resolved
echo-telemetry/src/main/java/com/netflix/spinnaker/echo/telemetry/TelemetryEventListener.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a
TelemetryEventDataProviderinterface. All registered implementations are called by theTelemetryEventListenerto fill out the stats payload we send over to the community metrics.I did this because @robzienert and I are talking about adding more complicated things. I can imagine them involving RPCs and caching and it's going to be much simpler to write and test if these implementations are factored out to separate classes instead of all jammed into
TelemetryEventListener.