fix(roles): file-based roles fail when the user is not provided in th…

…e file (#508) (#509) * handle case of null for file-based roles * add unit tests
spinnaker · Nov 19, 2019 · 47a6a00 · 47a6a00
1 parent 9dcab2c
commit 47a6a00
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/...-file/src/main/java/com/netflix/spinnaker/fiat/roles/file/FileBasedUserRolesProvider.java b/...-file/src/main/java/com/netflix/spinnaker/fiat/roles/file/FileBasedUserRolesProvider.java
@@ -26,11 +26,7 @@
 import java.io.FileReader;
 import java.io.IOException;
 import java.io.Reader;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 import java.util.stream.Collectors;
 import lombok.Data;
 import lombok.extern.slf4j.Slf4j;
@@ -59,7 +55,7 @@ private Map<String, List<Role>> parse(Reader source) throws IOException {
   @Override
   public List<Role> loadRoles(ExternalUser user) {
     try {
-      return new ArrayList<>(parse().get(user.getId()));
+      return Optional.ofNullable(parse().get(user.getId())).orElse(Collections.emptyList());
     } catch (IOException io) {
       log.error("Couldn't load roles for user " + user.getId() + " from file", io);
     }

diff --git a/...c/test/groovy/com/netflix/spinnaker/fiat/roles/file/FileBasedUserRolesProviderSpec.groovy b/...c/test/groovy/com/netflix/spinnaker/fiat/roles/file/FileBasedUserRolesProviderSpec.groovy
@@ -33,20 +33,24 @@ class FileBasedUserRolesProviderSpec extends Specification {
     when:
     def result1 = provider.loadRoles(externalUser("batman"))
     def result2 = provider.loadRoles(externalUser("foo"))
+    def result3 = provider.loadRoles(externalUser("spiderman"))
 
     then:
     result1.name.containsAll(["crimefighter", "jokerjailer"])
     result2.name.containsAll(["bar", "baz"])
+    result3 == []
 
     when:
-    def result3 = provider.multiLoadRoles([externalUser("batman")])
-    def result4 = provider.multiLoadRoles([externalUser("batman"), externalUser("foo")])
+    def result4 = provider.multiLoadRoles([externalUser("batman")])
+    def result5 = provider.multiLoadRoles([externalUser("batman"), externalUser("foo")])
+    def result6 = provider.multiLoadRoles([externalUser("spiderman")])
 
     then:
-    result3.containsKey("batman")
-    !result3.containsKey("foo")
+    result4.containsKey("batman")
+    !result4.containsKey("foo")
 
-    result4.keySet().containsAll("batman", "foo")
+    result5.keySet().containsAll("batman", "foo")
+    result6.keySet().size() == 0
   }
 
   private static ExternalUser externalUser(String id) {