fix(authorization): canCreate should not return void (#502) (#504)

Fixes Retrofit client for canCreate. Modifies create check endpoint for consistency.
spinnaker · Nov 6, 2019 · 9dcab2c · 9dcab2c
1 parent 2807538
commit 9dcab2c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/fiat-api/src/main/java/com/netflix/spinnaker/fiat/shared/FiatService.java b/fiat-api/src/main/java/com/netflix/spinnaker/fiat/shared/FiatService.java
@@ -58,8 +58,8 @@ Response hasAuthorization(
    * @param resourceType The type of the resource
    * @param resource The resource to check
    */
-  @POST("/authorize/{userId}/{resourceType}")
-  void canCreate(
+  @POST("/authorize/{userId}/{resourceType}/create")
+  Response canCreate(
       @Path("userId") String userId,
       @Path("resourceType") String resourceType,
       @Body Object resource);

diff --git a/fiat-web/src/main/java/com/netflix/spinnaker/fiat/controllers/AuthorizeController.java b/fiat-web/src/main/java/com/netflix/spinnaker/fiat/controllers/AuthorizeController.java
@@ -188,7 +188,7 @@ public void getUserAuthorization(
     response.setStatus(HttpServletResponse.SC_NOT_FOUND);
   }
 
-  @RequestMapping(value = "/{userId:.+}/{resourceType:.+}", method = RequestMethod.POST)
+  @RequestMapping(value = "/{userId:.+}/{resourceType:.+}/create", method = RequestMethod.POST)
   public void canCreate(
       @PathVariable String userId,
       @PathVariable String resourceType,