fix(authorization): canCreate should not return void (#502) #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Retrofit client for canCreate. Modifies create check endpoint for consistency.
cfieber
approved these changes
Nov 6, 2019
ezimanyi
deleted the
auto-cherry-pick-1.17-d61aef0036be5fb285acb361b2f6964f2db66651
branch
plumpy
added a commit
to plumpy/spinnaker.github.io
that referenced
this pull request
Nov 12, 2019
Something like spinnaker/fiat#504 arguably warranted an immediate 1.17.1 release (rather than waiting until the normal Monday release), but since the PR didn't actually say what it was fixing, it was pretty hard to tell.
dorbin
pushed a commit
to spinnaker/spinnaker.github.io
that referenced
this pull request
Nov 13, 2019
…1595) * docs(cherrypicks): make sure to specify bug details on a cherrypick Something like spinnaker/fiat#504 arguably warranted an immediate 1.17.1 release (rather than waiting until the normal Monday release), but since the PR didn't actually say what it was fixing, it was pretty hard to tell. * clarify that I mean 'github issue' * fix the spelling of GitHub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Retrofit client for canCreate.
Modifies create check endpoint for consistency.