Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Should fix the deletion of permissions when resource name is uppercase (backport #1012) #1013

Merged
merged 1 commit into from Feb 7, 2023
Merged

fix: Should fix the deletion of permissions when resource name is uppercase (backport #1012) #1013

merged 1 commit into from Feb 7, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2023

This is an automatic backport of pull request #1012 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@ovidiupopa07 @mergify
fix: Should fix the deletion of permissions when resource name is upp…
33374c8 
…ercase (#1012)

After the update to make all resource names lowercase, the user role sync process deletes the permission if the resource name (provided by the ResourceProvider) is in uppercase and the one in DB is in lowercase.

(cherry picked from commit 6d4bcfc)
@mergify mergify bot requested review from cfieber and jonsie as code owners February 7, 2023 14:59
@mergify mergify bot mentioned this pull request Feb 7, 2023
Merged
@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for merge label Feb 7, 2023
@link108 link108 merged commit 2088171 into release-1.28.x Feb 7, 2023
@link108 link108 deleted the mergify/bp/release-1.28.x/pr-1012 branch February 7, 2023 18:42
@mergify mergify bot added the auto merged label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmcintosh jasonmcintosh jasonmcintosh approved these changes

@cfieber cfieber Awaiting requested review from cfieber cfieber is a code owner

@jonsie jonsie Awaiting requested review from jonsie jonsie is a code owner

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.28
Projects
None yet
Milestone
No milestone
4 participants
@jasonmcintosh @link108 @spinnakerbot @ovidiupopa07