feat(roles): Add Execute as a type of Authorization #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibyom
commented
Apr 19, 2019
| @@ -106,8 +106,7 @@ public boolean isEmpty() { | |||
| .collect(Collectors.toSet()); | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| protected List<String> get(Authorization a) { | |||
| public List<String> get(Authorization a) { | |||
There was a problem hiding this comment.
This makes writing the migration easier as there isn't a easy way now to get a list of all groups who have READ or WRITE access.
dibyom
added a commit
to dibyom/fiat
that referenced
this pull request
Apr 26, 2019
jervi
added a commit
to jervi/deck
that referenced
this pull request
May 16, 2019
Applications saved before spinnaker#6901 and spinnaker/fiat#373 does not have EXECUTE permission set, and in some cases this breaks Deck. This commit fixes so that the old READ/WRITE permission is converted to a READ/EXECUTE/WRITE permission.
jervi
added a commit
to jervi/deck
that referenced
this pull request
May 16, 2019
Applications saved before spinnaker#6901 and spinnaker/fiat#373 does not have EXECUTE permission set, and in some cases this breaks Deck. This commit fixes so that the old READ/WRITE permission is converted to a READ/EXECUTE/WRITE permission.
dibyom
pushed a commit
to dibyom/deck
that referenced
this pull request
May 17, 2019
Applications saved before spinnaker#6901 and spinnaker/fiat#373 does not have EXECUTE permission set, and in some cases this breaks Deck. This commit fixes so that the old READ/WRITE permission is converted to a READ/EXECUTE/WRITE permission.
dibyom
added a commit
to spinnaker/deck
that referenced
this pull request
May 17, 2019
* fix(authz): Handle apps without execute permissions Applications saved before #6901 and spinnaker/fiat#373 does not have EXECUTE permission set, and in some cases this breaks Deck since `PermissionsConfigurer` always assumed apps had EXECUTE permissions set.
spinnakerbot
pushed a commit
to spinnaker/deck
that referenced
this pull request
May 17, 2019
* fix(authz): Handle apps without execute permissions Applications saved before #6901 and spinnaker/fiat#373 does not have EXECUTE permission set, and in some cases this breaks Deck since `PermissionsConfigurer` always assumed apps had EXECUTE permissions set.
dibyom
pushed a commit
to spinnaker/deck
that referenced
this pull request
May 17, 2019
* fix(authz): Handle apps without execute permissions Applications saved before #6901 and spinnaker/fiat#373 does not have EXECUTE permission set, and in some cases this breaks Deck since `PermissionsConfigurer` always assumed apps had EXECUTE permissions set.
clanesf
pushed a commit
to clanesf/fiat
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only adds the new type. Follow up PRs will:
Part of spinnaker/spinnaker#3554