feat(fiat): Add support for Redis SSL #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow Kork's existing pattern and check for presence of `rediss` in the URI Scheme. Follow Kork's existing usage of JedisPool() and supply optional parameter designating if SSL is enabled or disabled.
karlskewes
changed the title
robzienert
approved these changes
Jul 29, 2020
cfieber
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow Kork's existing pattern and check for presence of
redissinthe URI Scheme.
Follow Kork's existing usage of JedisPool() and supply optional
parameter designating if SSL is enabled or disabled.
Related to: spinnaker/spinnaker#5470
Tested with default in cluster redis (no auth or TLS) and
fiat.ymlsnippet below and mounting in Redis auth token via env var: