fix(github): Use new github teams api as old one is deprecated #907

thomaschaaf · 2022-03-01T16:06:20Z

https://github.blog/changelog/2022-02-22-sunset-notice-deprecated-teams-api-endpoints/

fiat-github/src/main/java/com/netflix/spinnaker/fiat/roles/github/client/GitHubClient.java

jasonmcintosh · 2022-03-01T16:20:07Z

https://github.com/spinnaker/fiat/blob/872873672b5910cb86f24b797eab90066a0ee531/fiat-github/src/main/java/com/netflix/spinnaker/fiat/roles/github/model/TeamMembership.java
I THINK this file can go away too since isMemberOfTeam on client isn't used... :)

...thub/src/main/java/com/netflix/spinnaker/fiat/roles/github/GithubTeamsUserRolesProvider.java

fiat-github/src/main/java/com/netflix/spinnaker/fiat/roles/github/client/GitHubClient.java

daconstenla · 2022-03-01T16:42:15Z

Suggested changes based on the output of ./gradlew :fiat-github:spotlessApply

jasonmcintosh · 2022-03-01T16:43:00Z

:) Was JUST about to suggest a spotlessApply :P

vide · 2022-03-01T16:55:31Z

I'm writing this here as a temporary emergency workaround to keep Spinnaker ticking if you have been bitten by this:
Edit your fiat config to include something like:

auth:
  groupMembership:
    service: FILE
    file:
      roleProviderType: FILE
      path: /opt/spinnaker/config/fiat-permissions.yml

(right now you should have service: GITHUB declared instead) and create a new file /opt/spinnaker/config/fiat-permissions.yml which might look like:

users:
- username: user
  roles:
  - teamA
  - teamB
- username: user2
  roles:
  - teamA
  - teamC
- username: jenkins
  roles:
  - jenkins

where the usernames maps to your GH users and the role to the GH teams (no need to put the Org scope)

dbyron-sf · 2022-03-01T17:09:02Z

Suggested changes based on the output of ./gradlew :fiat-github:spotlessApply

Yup, the builds are failing without these.

Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com>

link108 · 2022-03-01T19:49:01Z

@Mergifyio backport release-1.25.x release-1.26.x release-1.27.x

* fix(github): Use new github teams api https://github.blog/changelog/2022-02-22-sunset-notice-deprecated-teams-api-endpoints/ * refactor(github): Remove unused function * chore(gradle): spotless apply Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com> * refactor(github): clean up unused functions * refactor(github): delete unused model Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com> (cherry picked from commit 665b5fe)

mergify · 2022-03-01T19:51:39Z

backport release-1.25.x release-1.26.x release-1.27.x

✅ Backports have been created

#908 fix(github): Use new github teams api as old one is deprecated (backport #907) has been created for branch release-1.25.x
#909 fix(github): Use new github teams api as old one is deprecated (backport #907) has been created for branch release-1.26.x
#910 fix(github): Use new github teams api as old one is deprecated (backport #907) has been created for branch release-1.27.x

…#909) * fix(github): Use new github teams api https://github.blog/changelog/2022-02-22-sunset-notice-deprecated-teams-api-endpoints/ * refactor(github): Remove unused function * chore(gradle): spotless apply Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com> * refactor(github): clean up unused functions * refactor(github): delete unused model Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com> (cherry picked from commit 665b5fe) Co-authored-by: Thomas Schaaf <schaaf@komola.de>

…#910) * fix(github): Use new github teams api https://github.blog/changelog/2022-02-22-sunset-notice-deprecated-teams-api-endpoints/ * refactor(github): Remove unused function * chore(gradle): spotless apply Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com> * refactor(github): clean up unused functions * refactor(github): delete unused model Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com> (cherry picked from commit 665b5fe) Co-authored-by: Thomas Schaaf <schaaf@komola.de>

…ort #907) (#908) * fix(github): Use new github teams api as old one is deprecated (#907) * fix(github): Use new github teams api https://github.blog/changelog/2022-02-22-sunset-notice-deprecated-teams-api-endpoints/ * refactor(github): Remove unused function * chore(gradle): spotless apply Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com> * refactor(github): clean up unused functions * refactor(github): delete unused model Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com> (cherry picked from commit 665b5fe) * chore(deps): use new maven Co-authored-by: Thomas Schaaf <schaaf@komola.de> Co-authored-by: Cameron Motevasselani <cameron@armory.io>

Badbond · 2022-03-07T10:48:26Z

Thank you for merging the fix. When can we expect the releases to be rolled out? ~~In approx. 25 hours there will be another 24 hour brownout for the deprecated GitHub API~~. We wish to upgrade our current deployment using Halyard before then if possible.

Edit: Sorry, I see that they announced they paused the second brownout.

vide · 2022-03-08T12:12:03Z

@Badbond it looks like they paused not just the 2nd brownout but the whole sunsetting schedule, I guess Spinnaker wasn't the only project hit by this change.

…aker#907) (spinnaker#909) * fix(github): Use new github teams api https://github.blog/changelog/2022-02-22-sunset-notice-deprecated-teams-api-endpoints/ * refactor(github): Remove unused function * chore(gradle): spotless apply Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com> * refactor(github): clean up unused functions * refactor(github): delete unused model Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com> (cherry picked from commit 665b5fe) Co-authored-by: Thomas Schaaf <schaaf@komola.de>

fix(github): Use new github teams api

3fe84d7

https://github.blog/changelog/2022-02-22-sunset-notice-deprecated-teams-api-endpoints/

thomaschaaf requested review from cfieber and jonsie as code owners March 1, 2022 16:06

refactor(github): Remove unused function

836fac8

thomaschaaf commented Mar 1, 2022

View reviewed changes

fiat-github/src/main/java/com/netflix/spinnaker/fiat/roles/github/client/GitHubClient.java Show resolved Hide resolved

daconstenla reviewed Mar 1, 2022

View reviewed changes

...thub/src/main/java/com/netflix/spinnaker/fiat/roles/github/GithubTeamsUserRolesProvider.java Outdated Show resolved Hide resolved

daconstenla reviewed Mar 1, 2022

View reviewed changes

...thub/src/main/java/com/netflix/spinnaker/fiat/roles/github/GithubTeamsUserRolesProvider.java Outdated Show resolved Hide resolved

daconstenla reviewed Mar 1, 2022

View reviewed changes

fiat-github/src/main/java/com/netflix/spinnaker/fiat/roles/github/client/GitHubClient.java Outdated Show resolved Hide resolved

thomaschaaf and others added 3 commits March 1, 2022 19:21

chore(gradle): spotless apply

9382ce4

Co-authored-by: David Constenla <1520001+daconstenla@users.noreply.github.com>

refactor(github): clean up unused functions

522aea5

refactor(github): delete unused model

e242941

dbyron-sf approved these changes Mar 1, 2022

View reviewed changes

dbyron-sf added the ready to merge Approved and ready for merge label Mar 1, 2022

link108 approved these changes Mar 1, 2022

View reviewed changes

mergify bot added the auto merged label Mar 1, 2022

mergify bot merged commit 665b5fe into spinnaker:master Mar 1, 2022

spinnakerbot added the target-release/1.28 label Mar 1, 2022

mergify bot mentioned this pull request Mar 1, 2022

fix(github): Use new github teams api as old one is deprecated (backport #907) #908

Merged

mergify bot mentioned this pull request Mar 1, 2022

fix(github): Use new github teams api as old one is deprecated (backport #907) #909

Merged

mergify bot mentioned this pull request Mar 1, 2022

fix(github): Use new github teams api as old one is deprecated (backport #907) #910

Merged

link108 mentioned this pull request Mar 2, 2022

fix(gitub): using team slug instead of id #911

Merged

vide mentioned this pull request Mar 7, 2022

v1.24.x Orca hits 404s attempting to communicate with Clouddriver endpoints spinnaker/spinnaker#6337

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(github): Use new github teams api as old one is deprecated #907

fix(github): Use new github teams api as old one is deprecated #907

thomaschaaf commented Mar 1, 2022

jasonmcintosh commented Mar 1, 2022

daconstenla commented Mar 1, 2022

jasonmcintosh commented Mar 1, 2022

vide commented Mar 1, 2022

dbyron-sf commented Mar 1, 2022

link108 commented Mar 1, 2022

mergify bot commented Mar 1, 2022

Badbond commented Mar 7, 2022 •

edited

vide commented Mar 8, 2022 •

edited

fix(github): Use new github teams api as old one is deprecated #907

fix(github): Use new github teams api as old one is deprecated #907

Conversation

thomaschaaf commented Mar 1, 2022

jasonmcintosh commented Mar 1, 2022

daconstenla commented Mar 1, 2022

jasonmcintosh commented Mar 1, 2022

vide commented Mar 1, 2022

dbyron-sf commented Mar 1, 2022

link108 commented Mar 1, 2022

mergify bot commented Mar 1, 2022

✅ Backports have been created

Badbond commented Mar 7, 2022 • edited

vide commented Mar 8, 2022 • edited

Badbond commented Mar 7, 2022 •

edited

vide commented Mar 8, 2022 •

edited