fix(Pipeline template/front50): Bug fix 6340 #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2021 16:51
…he template instead of request param
…he template instead of request param
pemmasanikrishna
changed the title
|
@ajordens @KeisukeYamashita can you please look into this |
|
@Mergifyio update |
|
@mattgogerly is not allowed to run commands |
Brutal.. @pemmasanikrishna please fetch upstream |
|
@mattgogerly done |
mattgogerly
approved these changes
Sep 20, 2021
|
@Mergifyio update |
✅ Branch has been successfully updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 6340
When the tag is passed from the pipeline template, currently it's getting persisted without getting validated. The current fix has the first priority to the tag passed explicitly via request param, if it's not present, then it considers the one given in the template if any.