Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): revert fix type mismatch regression with Pipeline boolean properties (#1046) #1068

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix(api): revert fix type mismatch regression with Pipeline boolean properties (#1046) #1068

merged 1 commit into from
Sep 29, 2021

Conversation

cristhian-castaneda
Copy link
Member

@cristhian-castaneda cristhian-castaneda commented Sep 29, 2021 •
edited
Loading

The original type for these properties on deck is defined as boolean so we should keep it as is.

Image 2021-09-29 at 3 01 35 PM

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

edgarulg
edgarulg approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@edgarulg edgarulg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cristhian-castaneda cristhian-castaneda changed the title Revert "fix(api): fix type mismatch regression with Pipeline boolean properties (#1046) fix(api): revert fix type mismatch regression with Pipeline boolean properties (#1046) Sep 29, 2021
@edgarulg edgarulg merged commit 66dc951 into spinnaker:master Sep 29, 2021
@edgarulg
Copy link
Contributor

@Mergifyio backport release-1.27.x

mergify bot pushed a commit that referenced this pull request Sep 29, 2021
@cristhian-castaneda
Revert "fix(api): fix type mismatch regression with Pipeline boolean …
270c680 
…properties (#1046)" (#1068)

This reverts commit b082bae.

(cherry picked from commit 66dc951)
@mergify mergify bot mentioned this pull request Sep 29, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2021

Command backport release-1.27.x: success

Backports have been created

edgarulg pushed a commit that referenced this pull request Sep 29, 2021
@mergify @cristhian-castaneda
Revert "fix(api): fix type mismatch regression with Pipeline boolean …
bd3eb33 
…properties (#1046)" (#1068) (#1069)

This reverts commit b082bae.

(cherry picked from commit 66dc951)

Co-authored-by: Cristhian Castaneda <ccastanedarivera@gmail.com>
@cristhian-castaneda cristhian-castaneda deleted the revert-booleans-pipeline branch September 29, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarulg edgarulg edgarulg approved these changes

Assignees
No one assigned
Labels
target-release/1.28
Projects
None yet
Milestone
No milestone
3 participants
@cristhian-castaneda @spinnakerbot @edgarulg