-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fiat): Fix access denied for new apps with no roles #597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely the type of change that should have a test along with it. If / when we get to refactoring this away from Groovy, we would be likely introduce a regression with this conditional due to incorrectly translating Groovy Truth. :(
ed: Change itself seems legit, though.
Good point, @robzienert! |
90dbb48
to
c09eaea
Compare
Signed-off-by: Constantin Muraru <cmuraru@adobe.com>
Fixes spinnaker/spinnaker#1930
Previous behavior (with LDAP enabled):
AccessDeniedException: Access is denied
is thrown.Access denied
error will be resolved.Behavior after this PR: