Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug(notifications): Improve debug logging for notification callbacks #1225

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

luispollo
Copy link
Contributor

I added quite a lot of logging around notification callbacks when I initially rolled this out, but obviously not in the one place where we're seeing an issue now. 😝

This PR adds debug logging around building the proxy request to echo on callbacks, and also adds a bit of additional error handling for retrofit errors such that we hopefully return a better response in error cases.

@luispollo luispollo self-assigned this Jun 1, 2020
@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 0dd0366: debug(notifications): Improve debug logging for notification callbacks

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@luispollo luispollo merged commit 5c84f77 into spinnaker:master Jun 1, 2020
@luispollo luispollo deleted the md-slack-debug branch June 1, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants