feat(permissions): Add permissions support for accounts in halyard. #954
Conversation
| @@ -42,10 +43,17 @@ | |||
|
|
|||
| @Parameter( | |||
| variableArity = true, | |||
| names = "--required-group-membership", | |||
| description = AccountCommandProperties.REQUIRED_GROUP_MEMBERSHIP_DESCRIPTION | |||
| names = "--read-permissions", | |||
There was a problem hiding this comment.
These flags may no longer be functional in the latest spinnaker release, but still work in older ones. I would not remove them here.
There was a problem hiding this comment.
@lwander
Is there a deprecation process by which these flags should be removed at some time in the future?
There was a problem hiding this comment.
There is an annotation for flags that don't work until a certain release -- we need to add/extend that annotation for flags that no longer work after a certain release. That can be done in a separate PR.
|
Reverted the deletions |
stewchen
force-pushed
the
permissions
branch
2 times, most recently
from
4f90a03
to
842d854
Compare
| @@ -21,4 +21,8 @@ | |||
| public static final String REQUIRED_GROUP_MEMBERSHIP_DESCRIPTION = "A user must be a member of at least one specified group in order to make changes to this account's cloud resources."; | |||
|
|
|||
| public static final String PROVIDER_VERSION_DESCRIPTION = "Some providers support multiple versions/release tracks. This allows you to pick the version of the provider (not the resources it manages) to run within Spinnaker."; | |||
|
|
|||
| public static final String READ_PERMISSION_DESCRIPTION = "A user must have matching roles of all of these read permissions in order to view this account's cloud resources."; | |||
There was a problem hiding this comment.
A user must have _at least one_ of these roles in order to be granted the READ` permission. Same with the write description
|
Docs update pending the release: spinnaker/spinnaker.github.io#813 |
This change also removes the deprecated --requiredGroupMembership flags,
as they are no longer functional.