Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java17): resolve remaining access to private fields, run tests on JRE 17 #1173

Merged
merged 1 commit into from Sep 20, 2023
Merged

fix(java17): resolve remaining access to private fields, run tests on JRE 17 #1173

merged 1 commit into from Sep 20, 2023

Conversation

mattgogerly
Copy link
Member

fastTime and size are no longer accessible fields. Replace with getTime() and size() respectively. IntelliJ shows no remaining access related issues (not to say there aren't more hiding).

Additionally, run tests using JRE 17 to catch this stuff earlier.

Note: this does not resolve the issue reported relating to Instant.seconds - further PR to come in Kork for that one.

@mattgogerly
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2023

update

✅ Branch has been successfully updated

@mattgogerly mattgogerly added the ready to merge Approved and ready for merge label Sep 20, 2023
@mergify mergify bot added the auto merged label Sep 20, 2023
@mergify mergify bot merged commit d1f6ed8 into master Sep 20, 2023
5 checks passed
@mattgogerly mattgogerly deleted the fix/jre17 branch September 20, 2023 14:33
@mattgogerly
Copy link
Member Author

@Mergifyio backport release-1.32.x

@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2023 •
edited

backport release-1.32.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 20, 2023
@mattgogerly @mergify
fix(java17): stop accessing private fields, run tests using JRE17 (#1173
c046430 
)

(cherry picked from commit d1f6ed8)
@mergify mergify bot mentioned this pull request Sep 20, 2023
Merged
mergify bot added a commit that referenced this pull request Sep 20, 2023
@mergify @mattgogerly
fix(java17): stop accessing private fields, run tests using JRE17 (#1173
95c19bd 
) (#1175)

(cherry picked from commit d1f6ed8)

Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmcintosh jasonmcintosh jasonmcintosh approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.33
Projects
None yet
Milestone
No milestone
3 participants
@mattgogerly @jasonmcintosh @spinnakerbot