Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(travis): Properly return API triggered builds #1256

Merged
merged 1 commit into from
May 8, 2024

Conversation

jervi
Copy link
Contributor

@jervi jervi commented May 8, 2024

When populating the build dropdown for manual executions, manually triggered builds are missing for Travis Enterprise version 3.0.54 and newer. Before these builds had the same event_type=push as other builds, but now they have event_type=api. Adding api to the filtering fixes the issue.

When populating the build dropdown for manual executions, manually triggered builds are missing for Travis Enterprise version 3.0.54 and newer.
Before these builds had the same `event_type=push` as other builds, but now they have `event_type=api`. Adding `api` to the filtering fixes the issue.
@dbyron-sf
Copy link
Contributor

What about older versions of Travis Enterprise?

@jervi
Copy link
Contributor Author

jervi commented May 8, 2024

What about older versions of Travis Enterprise?

Luckily this filter accepts anything, so it will just silently ignore any unknown event types.

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label May 8, 2024
@mergify mergify bot added the auto merged label May 8, 2024
@mergify mergify bot merged commit 73354d5 into spinnaker:master May 8, 2024
4 checks passed
@jervi jervi deleted the travis_detect_api_triggered_builds branch May 13, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants