fix(boot2): Allow paths with URL-encoded slashes #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring Boot 2 tightened up restrictions, but CI job names may legitimately include encoded slashes See spinnaker/spinnaker#4477
|
I would love to actually add a test for this, but none of the tests I looked at seemed to actually run requests through the Spring request handling logic (which is what is changed here) and I was hoping to limit the amount of new test boilerplate for this fix. It would also be nice to just relax this for the specific endpoints that need it, but it's not clear that we can do that with |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Boot 2 tightened up restrictions, but CI job names may legitimately include encoded slashes
See spinnaker/spinnaker#4477
https://spinnakerteam.slack.com/archives/C091CCWRJ/p1559269913055000