Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boot2): Allow url-encoded % in URLs #499

Merged
merged 2 commits into from
Sep 4, 2019

Conversation

avram
Copy link
Contributor

@avram avram commented Aug 31, 2019

Follow-up to #454

Before:

$ curl localhost:8088/jobs/master/%25
{"timestamp":"2019-08-31T01:45:37.293+0000","status":500,"error":"Internal Server Error","message":"The request was rejected because the URL contained a potentially malicious String \"%25\""}%

After:

$ curl localhost:8088/jobs/master/%25
{"timestamp":"2019-08-31T01:46:30.379+0000","status":404,"error":"Not Found","message":"Master 'master' does not exist"}%

As previously noted, we don't seem to have any existing tests that make actual requests that route through StrictFirewall.

@louisjimenez
Copy link

@emjburns could you take a quick look at this before merging?

@emjburns
Copy link
Contributor

emjburns commented Sep 4, 2019

LGTM

@emjburns emjburns merged commit d087e74 into spinnaker:master Sep 4, 2019
@tonyg4864
Copy link

Thanks, I have validated this on release-1.16.x-latest-validated and it works.

@avram avram deleted the fix-encoded-percent branch September 9, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants