First pass at: #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
duftler
commented
Feb 18, 2017
duftler
commented
- Credentials handling
- Google configuration
- Stackdriver configuration
- /fetch entrypoint (mainly a placeholder at the moment)
|
@lwander please review. |
lwander
approved these changes
Feb 18, 2017
| public interface MetricsService { | ||
| boolean servicesAccount(String accountName); | ||
| Map queryMetrics(String accountName, | ||
| String instanceNamePrefix, |
There was a problem hiding this comment.
Is Kayenta going to be restricted to only canarying instances, or is this just part of the first pass?
There was a problem hiding this comment.
Just first pass stuff.
kayenta-google/lombok.config
Outdated
| @@ -0,0 +1,2 @@ | |||
| lombok.nonNull.exceptionType = IllegalArgumentException | |||
There was a problem hiding this comment.
Any reason why we aren't configuring lombok for the whole project, but rather just the submodules?
There was a problem hiding this comment.
No good reason, just evolved that way. Created just one in the root dir and deleted the others.
| String jsonKey = googleManagedAccount.getJsonKey(); | ||
| GoogleCredentials googleCredentials = | ||
| StringUtils.hasLength(jsonKey) | ||
| ? new GoogleJsonCredentials(project, jsonKey) |
- Credentials handling - Google configuration - Stackdriver configuration - /fetch entrypoint (mainly a placeholder at the moment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.