Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(judge): Use the correct key to retrieve the metric direction. #204

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

csanden
Copy link
Contributor

@csanden csanden commented Jan 16, 2018

Use the correct key to retrieve the metric direction from the canary config.

@csanden csanden added the bug label Jan 16, 2018
@csanden csanden self-assigned this Jan 16, 2018
@skandragon
Copy link
Contributor

The converter used 'directionality', the judge used 'directionality', but the UI uses 'direction' -- I'd be inclined to say the UI should be what needs to be changed. However, either way we'll need to normalize this in the existing configs, so I'll merge this and run a job to do that before it's deployed.

@skandragon skandragon merged commit 38b3638 into master Jan 16, 2018
@skandragon skandragon deleted the fix/metric-direction branch January 16, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants