Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(builds): Introduces composite builds via gradle plugin #407

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

ttomsu
Copy link
Member

@ttomsu ttomsu commented Oct 25, 2018

Removes spring boot gradle plugin.

Ref: spinnaker/spinnaker#2844

Copy link
Collaborator

@duftler duftler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Would also like @skandragon to verify it build/runs ok in their env.
@fieldju Please verify that your integration tests till work (fair bit of gradle wizardry in here).

@fieldju
Copy link
Collaborator

fieldju commented Oct 25, 2018

The SignalFx integration tests still pass.

I noticed this change eliminates the ability to create a fatJar via ./gradlew bootRepackage -DspringBoot.repackage=true is there an alternative way to create the fatJar?

@duftler
Copy link
Collaborator

duftler commented Oct 25, 2018

I don't know the answer to that question. Maybe @ttomsu or @cfieber know.

@ttomsu ttomsu requested a review from cfieber October 25, 2018 16:51
@cfieber
Copy link
Contributor

cfieber commented Oct 25, 2018

@fieldju the gradle upgrade includes removal of the spring-boot plugin. If you do want to package a fatjar you could look at creating an init-script to include (similar to what we are doing when publishing is enabled via -I gradle/init-publish.gradle)

@fieldju
Copy link
Collaborator

fieldju commented Oct 25, 2018 via email

@ttomsu ttomsu merged commit e53f299 into spinnaker:master Oct 25, 2018
@ttomsu ttomsu deleted the composite-builds branch October 25, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants