Add more retries to more components #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duftler
reviewed
Nov 13, 2018
kayenta-atlas/src/main/java/com/netflix/kayenta/atlas/metrics/AtlasMetricsService.java
Outdated
Show resolved
Hide resolved
| @@ -29,7 +29,7 @@ | |||
| import com.netflix.kayenta.security.AccountCredentialsRepository; | |||
| import com.netflix.kayenta.storage.ObjectType; | |||
| import com.netflix.kayenta.storage.StorageService; | |||
| import com.netflix.spinnaker.kork.core.RetrySupport; | |||
| import com.netflix.kayenta.util.Retry; | |||
There was a problem hiding this comment.
It occurred to me after I finished reviewing the PR that I had seen this logic before. I search kayenta on github and ended up back at this file. Wouldn't it make more sense to just add the new logic to the existing RetrySupport class in kork?
There was a problem hiding this comment.
This is a temporary step along the path to make things more context aware, so I'd prefer to keep it inside kayenta for now.
Aloren
reviewed
Nov 21, 2018
|
|
||
| import java.util.function.Supplier; | ||
|
|
||
| public class Retry { |
There was a problem hiding this comment.
Please have a look at spring-retry.
It might be a good solution in case there is a need for more sophisticated retry policies: like configuring which types of exceptions should be retried, adding retry metrics or providing different backoff policies.
ybai2-sc
pushed a commit
to ybai2-sc/kayenta
that referenced
this pull request
Dec 20, 2018
* feat(retry): add a retry util * bug(retry): retry Atlas actions * bug(retry): improve retry in ConfigBin * bug(retry): retry some s3 calls that seem prone to failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I would like a more general approach, and this is not quite as clean as I'd like, it's a step toward getting things closer to sane.
I don't yet have metrics wired up, but will add this eventually; I may also split out the "call this method until it stops throwing exceptions" type of call now into a more sane context (http, atlas) aware retry system. For now, this will work better than what was there.