feat(signalfx): Provide additional context about the results of the signalflow programs. #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignalflow programs.
marchello2000
approved these changes
Oct 1, 2019
| @@ -56,6 +56,16 @@ | |||
| @Slf4j | |||
| public class SignalFxMetricsService implements MetricsService { | |||
|
|
|||
| private static final String SIGNAL_FLOW_ERROR_TEMPLATE = | |||
| "An error occurred whole executing the Signal Flow program. " | |||
There was a problem hiding this comment.
typo: whole -> while?
nisanharamati
approved these changes
Oct 1, 2019
duftler
reviewed
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that in Signal Fx if you have metrics that are reporting at differing frequencies.
Say a system agent on an EC2 instance that reports system cpu and memory at 1 data point per minute and application metrics that report 6 times per minute.
In Kayenta if you set the step to 10 (6 datapoints per minute) that the CPU and Memory data gets padded with a bunch of NaNs and gets graphed weird.
Just taking that data and stretching it had some side effects as well, so this PR adds more attributes to the data that flows through with the results so that the data can be reconstructed and graphed more accurately.
Before:
After:
CC: @melanahammel