fix(metrics): record drift from last resource check #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorin
commented
Apr 6, 2020
keel-core/src/main/kotlin/com/netflix/spinnaker/keel/actuation/CheckScheduler.kt
Show resolved
Hide resolved
gal-yardeni
reviewed
Apr 6, 2020
keel-core/src/main/kotlin/com/netflix/spinnaker/keel/telemetry/TelemetryListener.kt
Show resolved
Hide resolved
gal-yardeni
reviewed
Apr 6, 2020
keel-core/src/main/kotlin/com/netflix/spinnaker/keel/telemetry/TelemetryEvent.kt
Outdated
Show resolved
Hide resolved
|
rebased against master |
added 2 commits
April 7, 2020 15:01
Calculate the resource check drift metric (keel.resource.check.drift) by using the last time resource check succeeded as the start time. Previously, it was calculating based on the beginning of the actuation loop, which would drop to zero when the loop restarted due to timeout. Fixes spinnaker#950
…arting Remove ScheduledResourceCheckStarting since it's no longer used. Move ResourceCheckCompleted to a separate file.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate the resource check drift metric (keel.resource.check.drift)
by using the last time resource check succeeded as the start time.
Previously, it was calculating based on the beginning of the actuation
loop, which would drop to zero when the loop restarted due to timeout.
Fixes #950