Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): record drift from last resource check #976

Merged
merged 3 commits into from
Apr 7, 2020
Merged

fix(metrics): record drift from last resource check #976

merged 3 commits into from
Apr 7, 2020

Commits on Apr 7, 2020

  1. fix(metrics): record drift from last resource check 

    Calculate the resource check drift metric (keel.resource.check.drift)
by using the last time resource check succeeded as the start time.

Previously, it was calculating based on the beginning of the actuation
loop, which would drop to zero when the loop restarted due to timeout.

Fixes spinnaker#950
    Lorin Hochstein committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    d825811 View commit details
    Browse the repository at this point in the history

  2. fix(pr): move ResourceCheckCompleted, remove ScheduledResourceCheckSt… 

    …arting

Remove ScheduledResourceCheckStarting since it's no longer used.

Move ResourceCheckCompleted to a separate file.
    Lorin Hochstein committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    ec9a4c6 View commit details
    Browse the repository at this point in the history

  3. fix(pr): add missing import

    Lorin Hochstein committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    e081821 View commit details
    Browse the repository at this point in the history