chore(dependencies): upgrade pf4j from 3.2.0 to 3.10.0 to resolve CVE-2023-40828 #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-2023-40828 pf4j 3.10.0 brings in slf4j-api 2.0.6 which is not compatible with logback 1.2.x. Upgrading logback created incompatibility issues with Springboot's LogbackLoggingSystem. > Task :kork-tomcat:test com.netflix.spinnaker.kork.tomcat.CRLFHeaderTest > clientTest() FAILED java.lang.NoClassDefFoundError at LogbackLoggingSystem.java:293 Caused by: java.lang.ClassNotFoundException at BuiltinClassLoader.java:581 1 test completed, 1 failed Caused by: java.lang.ClassNotFoundException at BuiltinClassLoader.java:581 So, pin slf4j-api to 1.7.36 to retain compatibility with logback to 1.2.x. Removed a test(extensions index is written to META-INF) from TestPluginGeneratorTest.kt as the upgraded pf4j no longer create extensions.idx if no extensions exist.(refer pf4j/pf4j#508) Note: PluginWrapper is deprecated in 3.10.0 and will be removed in the next major release as per this - pf4j/pf4j#512. So next pf4j upgrade would break the functionality of existing plugins.
jasonmcintosh
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pf4j 3.10.0 brings in slf4j-api 2.0.6 which is not compatible with logback 1.2.x. Upgrading logback created incompatibility issues with Springboot's LogbackLoggingSystem.
So, pin slf4j-api to 1.7.36 to retain compatibility with logback to 1.2.x.
Removed a test(extensions index is written to META-INF) from TestPluginGeneratorTest.kt as the upgraded pf4j no longer create extensions.idx if no extensions exist.(refer pf4j/pf4j#508)
Note: PluginWrapper is deprecated in 3.10.0 and will be removed in the next major release as per this - pf4j/pf4j#512. So next pf4j upgrade would break the functionality of existing plugins.