feat(plugins): allow config to be super class on extension #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done in order to use the following pf4j feature with a configurable extension. "Support any interface as an ExtensionPoint" pf4j/pf4j#350 This is nice because I can extend something that is not an extension point, and even do it in safe mode. The problem is that now my extension can only have one interface. So I can't use the ConfigurableExtension directly. I can only have one interface unless pf4j is modified to allow more. Using my one super class slot for configuration is still not ideal, but it works. It might be nice to allow some other mechanism for config other than class hierarchy or modify pf4j to handle config natively.
|
This is purposefully built on kork 6.22.2 because I am testing this inside of Orca, which doesn't easily work with any newer version of kork. |
robzienert
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done in order to use the following pf4j feature with a configurable extension.
"Support any interface as an ExtensionPoint" pf4j/pf4j#350
This is nice because I can extend something that is not an extension point, and even do it in safe mode. The problem is that now my extension can only have one interface. So I can't use the ConfigurableExtension directly. I can only have one interface unless pf4j is modified to allow more.
Using my one super class slot for configuration is still not ideal, but it works. It might be nice to allow some other mechanism for config other than class hierarchy or modify pf4j to handle config natively.