Skip to content

Commit

Permalink
fix(bom): Fix generated pom.xml to omit invalid lombok declaration (#…
Browse files Browse the repository at this point in the history
…3017)

compileOnly dependency should not be added to generated pom.xml,
see discussion: https://discuss.gradle.org/t/publishing-plugin-should-respect-compileonly-configuration/22903/2
see related commit: nebula-plugins/nebula-publishing-plugin@a5432aa
  • Loading branch information
Aloren authored and marchello2000 committed Jul 7, 2019
1 parent 5f7a1d0 commit 58d7b98
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
3 changes: 3 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ buildscript {
classpath "com.netflix.spinnaker.gradle:spinnaker-dev-plugin:$spinnakerGradleVersion"
if (Boolean.valueOf(enablePublishing)) {
classpath "com.netflix.spinnaker.gradle:spinnaker-gradle-project:$spinnakerGradleVersion"
// TODO: nebula-publishing-plugin version override should be removed as soon as spinnaker-gradle-project is updated
// this override is needed to omit compileOnly dependencies from generated pom.xml
classpath "com.netflix.nebula:nebula-publishing-plugin:12.0.1"
}
classpath "com.netflix.nebula:nebula-kotlin-plugin:1.3.31"
classpath "org.jetbrains.kotlin:kotlin-allopen:1.3.31"
Expand Down
5 changes: 0 additions & 5 deletions orca-bom/orca-bom.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@
apply plugin: "java-platform"
apply plugin: "maven-publish"

// without this building the pom fails when using the Nebula publishing plugin
configurations {
create("compileOnly")
}

javaPlatform {
allowDependencies()
}
Expand Down

0 comments on commit 58d7b98

Please sign in to comment.