Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated pom.xml to omit invalid lombok declaration #3017

Merged
merged 3 commits into from
Jul 7, 2019

Conversation

Aloren
Copy link
Contributor

@Aloren Aloren commented Jul 1, 2019

compileOnly dependency should not be added to generated pom.xml,
see discussion: https://discuss.gradle.org/t/publishing-plugin-should-respect-compileonly-configuration/22903/2
see related commit: nebula-plugins/nebula-publishing-plugin@a5432aa

Currently all published pom.xml contain:

    <dependency>
      <groupId>org.projectlombok</groupId>
      <artifactId>lombok</artifactId>
      <version/>
      <scope>provided</scope>
    </dependency>

which is considered invalid by Maven and thus all transitive dependencies of such artifacts are omitted.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 0cc1d0a: Fix generated pom.xml to omit invalid lombok declaration

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@Aloren
Copy link
Contributor Author

Aloren commented Jul 4, 2019

changed commit message as requested by @spinnakerbot

@marchello2000 marchello2000 merged commit 58d7b98 into spinnaker:master Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants