fix(queue): don't rewrite parallel stage type with wrong thing

spinnaker · May 2, 2017 · e5754c6 · e5754c6
1 parent bc62c31
commit e5754c6
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/orca-queue/src/main/kotlin/com/netflix/spinnaker/orca/q/StageDefinitionBuilders.kt b/orca-queue/src/main/kotlin/com/netflix/spinnaker/orca/q/StageDefinitionBuilders.kt
@@ -160,7 +160,7 @@ private fun StageDefinitionBuilder.buildParallelStages(stage: Stage<out Executio
     val parallelContexts = parallelContexts(stage)
     parallelContexts
       .map { context ->
-      val execution = stage.getExecution()
+        val execution = stage.getExecution()
         val stageType = context.getOrDefault("type", stage.getType()).toString()
         val stageName = context.getOrDefault("name", stage.getName()).toString()
         @Suppress("UNCHECKED_CAST")
@@ -169,10 +169,8 @@ private fun StageDefinitionBuilder.buildParallelStages(stage: Stage<out Executio
           is Orchestration -> newStage(execution, stageType, stageName, context, stage as Stage<Orchestration>, STAGE_BEFORE)
           else -> throw IllegalStateException()
         }
-    }
+      }
       .forEachIndexed { i, it ->
-        // TODO: this is insane backwards nonsense, it doesn't need the child stage in any impl so we could determine this when building the stage in the first place
-        it.setType(getChildStageType(it))
         it.setRefId("${stage.getRefId()}=${i + 1}")
         it.setRequisiteStageRefIds(emptySet())
         stage.getExecution().apply {