refactor(*): Split redis code to its own module #2175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step one of v2 persistence. Functionally, nothing in this PR has changed. This PR breaks out all Redis code into its own
orca-redis
module:NotificationClusterLock
interface so ourNotificationPollingAgents
can have a locking implementation that may not necessarily be Redis. Also addedRedisNotificationClusterLock
which is functionally the same as what was there previously.orca-redis
. This includes the migrators that were inorca-front50
(strong doubts that they belonged in that module to begin with).orca-queue
.orca-core-tck
, which includesAbstractExecutionRepositoryTck
.Things to cleanup after this:
OldPipelineCleanup...Agent
andTopApplicationExecutionCleanup...Agent
were moved intoorca-redis
. Non-ideal. Will refactor these to be storage impl-agnostic in a separate PR.Other things of note:
orca-core
becauseExecutionRepository
includes it as part of its API. Womp womp. From the looks, that's the only spot, though.orca-sql
in place & baseline Spring config to run Redis vs SQL (and also Redis & SQL for red/black).