feat(queue): Add hydrate queue admin command #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robzienert
force-pushed
the
hydrate-queue
branch
3 times, most recently
from
6ed9e97
to
403f3bf
Compare
|
I presume that |
|
@robfletcher That's correct. We collect all of the messages with their descriptions and then just |
robzienert
force-pushed
the
hydrate-queue
branch
from
403f3bf
to
1be42eb
Compare
robfletcher
approved these changes
Jul 12, 2018
| it("adds messages to the queue") { | ||
| argumentCaptor<Message>().let { | ||
| verify(queue, times(1)).push(it.capture()) | ||
| assertType<CompleteStage>(it.firstValue) { |
There was a problem hiding this comment.
Can you not just use argumentCaptor<CompleteStage> in the first place?
There was a problem hiding this comment.
Yes I can. Victimized by copy/paste.
robzienert
force-pushed
the
hydrate-queue
branch
4 times, most recently
from
a9d3df5
to
5cecbcb
Compare
robzienert
force-pushed
the
hydrate-queue
branch
from
5cecbcb
to
e32f4bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the ability to hydrate the work queue from the execution repository state. This is primarily intended for being able to recover a Redis failure while using the (upcoming) SQL backend, where losing the Redis will mean in-flight work is orphaned, but its state is still held in SQL and thus is recoverable.
A secondary use case can be made for "kicking" a stuck execution where a message was dropped and the execution is no longer progressing. Running the command against a single execution could potentially get things going again.
Example output from the API:
{ "dryRun": true, "executions": { "01CJ3DVSNE4BG85HNNJKDT0P05": { "startTime": 1531271047636, "actions": [ { "description": "Task is running and is retryable", "message": { "kind": "runTask", "executionType": "PIPELINE", "executionId": "01CJ3DVSNE4BG85HNNJKDT0P05", "application": "spintest", "stageId": "01CJ3DVSNFYA753Y7RAXEHJD72", "taskId": "1", "taskType": "com.netflix.spinnaker.orca.pipeline.tasks.WaitTask", "attributes": [], "ackTimeoutMs": 600000 }, "context": { "stageId": "01CJ3DVSNFYA753Y7RAXEHJD72", "stageType": "wait", "stageStartTime": 1531271051731, "taskId": "1", "taskType": "wait", "taskStartTime": 1531271051839 } } ], "canApply": true } } }Example log output:
I probably need more tests, what other use cases should I be covering?