feat(kubernetes): Skip loading events for manifest retrieval in WaitF… #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2019
Merged
ezimanyi
reviewed
Jun 20, 2019
There was a problem hiding this comment.
I'll take a closer look after any changes to support the changes in spinnaker/clouddriver#3796 are made here.
I think a similar change here would make sense, where we just always require calls to getManifest to pass in includeEvents. I think that actually from orca we'll never need events as the only other call is from FindArtifactsFromResource and that also immediately discards any events on the returned object so all calls can probably just pass false there.
…orManifestStableTask
|
Alright, addressed review comments and the corresponding clouddriver PR has also been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes use of the changes in spinnaker/clouddriver#3796 to skip loading events when retrieving manifests in WaitForManifestStableTask.
We ran into this scenario when we had a lot of deployment pipelines running concurrently, and each deployment involved a decent number of manifests (~30). This task iterates through the manifests involved in the deployment and calls the retrieve manifest API for each one, which (when live manifest mode is enabled) causes a lot of full event loads to occur, which tanks (in our case) the kubernetes API server.
WaitForManifestStableTask does not actually need any event information to do its job, so in this particular case we can skip loading events and prevent the extra load on the kubernetes api server.