Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google): do not pin source server group capacity in red/black #3181

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

maggieneterval
Copy link
Contributor

Closes spinnaker/spinnaker#4812

  • When deploying to AWS, only the rolling red/black strategy pins the source server group's min capacity to its desired capacity (see AwsDeployStagePreProcessor and this conversation for details on how/why).
  • This change brings the GCE implementation of red/black to parity with the AWS implementation: we will no longer pin the source server group's min capacity to its desired capacity. The potential drawback to this is that during the period when both the source and target server groups are taking traffic, the autoscaler may scale down the source server group as it will only be taking 50% of the traffic: in the case a rollback is necessary, it will need to scale back up. However, as Netflix has experienced, the potential downsides of pinning the source server group are much worse, as there are many unpredictable ways to get into a state where the server group is never unpinned (see Netflix post-mortem here).
  • The other upside of bringing the GCE red/black to parity with the AWS red/black is the maintainability of the common strategy code, which @marchello2000 is currently refactoring.
  • In the next Spinnaker release (1.17), I will summarize the rationale behind this change in the release notes so that any GCE users relying on the existing functionality are aware of the change.

Copy link
Member

@plumpy plumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted code is the best kind of code!

🥇

@maggieneterval maggieneterval merged commit 2c591c8 into spinnaker:master Sep 19, 2019
@maggieneterval maggieneterval deleted the dont-pin-redblack branch September 19, 2019 20:47
maggieneterval added a commit to maggieneterval/orca that referenced this pull request Sep 24, 2019
…innaker#3181)

* fix(google): do not pin source server group capacity in red/black

* fix(google): remove unnecessary method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pinMinimumCapacity on pipeline termination doesn't rollback original capacity
3 participants