feat(plugins): Add kork-plugins, wire up initial spel function extension point #3242
Conversation
robzienert
force-pushed
the
spel-func-extensionpoint
branch
from
2b53436
to
bd5013b
Compare
| import org.jetbrains.annotations.Nullable; | ||
| import org.pf4j.Extension; | ||
|
|
||
| @Extension |
There was a problem hiding this comment.
So this would essentially be a "system extension"?
There was a problem hiding this comment.
That's right. Although I'm gonna delete this from the PR. I didn't mean for it to come along for the ride.
There was a problem hiding this comment.
it seems that if functions can be expanded we might need a way for the extension to provide additional extraAllowedReturnTypes for example, but we can tackle that later, obviosly
There was a problem hiding this comment.
Yeah, I have no intention of changing how spel function customization is done, only in providing new ways to provde said functions.
| @@ -132,8 +137,8 @@ UserConfiguredUrlRestrictions userConfiguredUrlRestrictions( | |||
|
|
|||
| @Bean | |||
| public ContextParameterProcessor contextParameterProcessor( | |||
| List<ExpressionFunctionProvider> expressionFunctionProviders) { | |||
| return new ContextParameterProcessor(expressionFunctionProviders); | |||
| List<ExpressionFunctionProvider> expressionFunctionProviders, PluginManager pluginManager) { | |||
There was a problem hiding this comment.
where is the bean for PluginManager, i am confused...
There was a problem hiding this comment.
oh, does it come from pf4j?
There was a problem hiding this comment.
I think it comes from SpinnakerPluginManager which is configured in Kork
robzienert
force-pushed
the
spel-func-extensionpoint
branch
2 times, most recently
from
2b54fc2
to
78b90ba
Compare
robzienert
force-pushed
the
spel-func-extensionpoint
branch
from
78b90ba
to
f9f6a31
Compare
Depends on spinnaker/kork#398