fix(monitored deploy): add deploymentId parameter #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monitors need an ability to correlate calls to their API. This adds a `deploymentId` parameter to all requests (which is really the `stageId` for the `createServerGroup` stage) This allows the monitor to correlate e.g. `evaluateHealth @ 20%` and `evaluateHealth @ 50%` to the same cluster Especially if multiple shards are deployed in the same pipeline
dreynaud
reviewed
Oct 25, 2019
| @@ -42,6 +81,7 @@ protected void fromStage(Stage stage) { | |||
| application = stage.getExecution().getApplication(); | |||
| executionId = stage.getExecution().getId(); | |||
| stageId = stage.getId(); | |||
| deploymentId = stage.getParentStageId(); | |||
There was a problem hiding this comment.
does stage id actually identify a deployment? Why not execution id?
There was a problem hiding this comment.
The createServerGroup (parent) stage does - executionId is already there but it doesn't work when the same pipeline has multiple deploy stages. createServerGroup works because even if a deploy stage deploys N clusters there will be N createServerGroup stages and all steps will be their children
dreynaud
approved these changes
Oct 25, 2019
|
Thanks for adding the comments @marchello2000 , super helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitors need an ability to correlate calls to their API.
This adds a
deploymentIdparameter to all requests (which is really thestageIdfor thecreateServerGroupstage)This allows the monitor to correlate e.g.
evaluateHealth @ 20%andevaluateHealth @ 50%to the same clusterEspecially if multiple shards are deployed in the same pipeline