fix(dependent pipelines): failure to trigger a dependend pipeline shouldn't affect others #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uldn't affect others Failure in planning a, say, a single v2 templated pipeline will cause no dependent pipelines to start. This is due to exception not being localized to each individual pipeline
marchello2000
commented
Oct 25, 2019
| } else { | ||
| return pipeline | ||
| } | ||
| } | ||
| }.findAll({ pipeline -> |
There was a problem hiding this comment.
oh, i don't need this anymore...
…ine shouldn't affect others
marchello2000
commented
Oct 25, 2019
| try { | ||
| return V2Util.planPipeline(contextParameterProcessor, executionPreprocessors, pipeline) | ||
| } catch (Exception e) { | ||
| log.error("Failed to plan V2 templated pipeline {}", pipeline.getOrDefault("id", "<UNKNOWN ID>"), e) |
There was a problem hiding this comment.
should prob add a metric for this? what do you think @dreynaud ?
There was a problem hiding this comment.
thought unless it's on the dashboard noone will look at it.. 🤷♂
There was a problem hiding this comment.
I don't think there's necessarily a lot of value in throwing that on a dashboard. Is it a page-able offense though? If yes it deserves a metric, otherwise let's keep it in logs
louisjimenez
approved these changes
Oct 25, 2019
emjburns
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure in planning a, say, a single v2 templated pipeline will cause no dependent pipelines to start.
This is due to exception not being localized to each individual pipeline