-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kustomize): add kustomizeFilePath to support gitrepo artifact type #3260
Conversation
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
@spinnakerbot assign @ezimanyi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me!
This adds an additional property (
kustomizeFilePath
) toBakeManifestContext
andKustomizeBakeManifestRequest
. This property is required by Kustomize when using thegit/repo
artifact type.This PR is associated with another in Rosco (spinnaker/rosco#449) and another (yet to be created) in Deck. The git/repo artifact type was added to Clouddriver with the following PR: spinnaker/clouddriver#4049