feat(git/repo): add git/repo artifact support in kustomize bake manifest #7572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ezimanyi - tagging you so you're aware! |
maggieneterval
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Code looks fine, left a few suggestions and questions inline. Guessing we should hold this until the corresponding service changes are merged? Also just want to verify that this has been tested with the artifacts rewrite feature flag both enabled and disabled? The screenshot in the PR description shows an artifact inline in the bake stage, but also want to verify that one could define a git repo artifact in the Expected Artifacts section of the pipeline config. Thank you! 🙏
...s/modules/core/src/pipeline/config/stages/bakeManifest/kustomize/BakeKustomizeConfigForm.tsx
Outdated
Show resolved
Hide resolved
...s/modules/core/src/pipeline/config/stages/bakeManifest/kustomize/BakeKustomizeConfigForm.tsx
Outdated
Show resolved
Hide resolved
...cripts/modules/core/src/pipeline/config/triggers/artifacts/gitrepo/GitRepoArtifactEditor.tsx
Outdated
Show resolved
Hide resolved
| <StageArtifactSelectorDelegate | ||
| artifact={this.getInputArtifact().artifact} | ||
| excludedArtifactTypePatterns={[]} | ||
| excludedArtifactTypePatterns={excludeAllTypesExcept(ArtifactTypePatterns.GIT_REPO)} |
There was a problem hiding this comment.
So now that we only accept the new git repo artifact type in Kustomize stages, will all previously configured Kustomize stages break?
There was a problem hiding this comment.
In the UI, yes. We expected this so we called Kustomize support Beta in the last release. We're leaving the old code in place (for now) so it should continue to work. We'll come up with a communication plan for when the old path will be removed.
|
|
||
| return ( | ||
| <> | ||
| <StageConfigField label="URL" helpKey="pipeline.config.expectedArtifact.gitrepo.url"> |
There was a problem hiding this comment.
Just a heads up that in new stages, we are trying to move to FormikStageConfig / FormikFormField rather than StageConfigField -- see ScriptStageConfig.tsx for an example.
There was a problem hiding this comment.
Ah, good to know! I'll check out that example, thanks. Is this something we want changed now or refactored after the merge?
There was a problem hiding this comment.
We can refactor after the merge, I think the rest of the Bake (Manifest) stage is still written with StageConfigField so we'd probably want to swap them all out at once in a later commit so the styling is consistent.
|
Yep, it works with both |
…st/kustomize/BakeKustomizeConfigForm.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com>
…st/kustomize/BakeKustomizeConfigForm.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com>
…s/gitrepo/GitRepoArtifactEditor.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com>
|
@KathrynLewis Awesome, thank you! 🙏 |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 30, 2019
34a3b00 feat(managed): Update resource indicators to use new data source 7b33d2b feat(managed): Join managed data to infra data, add moniker to Security Groups d4c89ce feat(managed): Use new data source for 'Managed Resources' config section efcceb3 feat(managed): add 'managedResources' data source 4ed015a feat(dataSources): widen + parameterize types, add default values 8c29cba Reactify titus launch configuration (spinnaker#7581) 5d89a04 feat(google): add gce scale-down controls (spinnaker#7570) f882544 feat(git/repo): add git/repo artifact support in kustomize bake manifest (spinnaker#7572)
christopherthielen
added a commit
that referenced
this pull request
Oct 30, 2019
34a3b00 feat(managed): Update resource indicators to use new data source 7b33d2b feat(managed): Join managed data to infra data, add moniker to Security Groups d4c89ce feat(managed): Use new data source for 'Managed Resources' config section efcceb3 feat(managed): add 'managedResources' data source 4ed015a feat(dataSources): widen + parameterize types, add default values 8c29cba Reactify titus launch configuration (#7581) 5d89a04 feat(google): add gce scale-down controls (#7570) f882544 feat(git/repo): add git/repo artifact support in kustomize bake manifest (#7572)
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Nov 8, 2019
…est (spinnaker#7572) * feat(git/repo): add git/repo artifact support in kustomize bake manifest * Update app/scripts/modules/core/src/pipeline/config/stages/bakeManifest/kustomize/BakeKustomizeConfigForm.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com> * Update app/scripts/modules/core/src/pipeline/config/stages/bakeManifest/kustomize/BakeKustomizeConfigForm.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com> * Update app/scripts/modules/core/src/pipeline/config/triggers/artifacts/gitrepo/GitRepoArtifactEditor.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com>
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Nov 8, 2019
34a3b00 feat(managed): Update resource indicators to use new data source 7b33d2b feat(managed): Join managed data to infra data, add moniker to Security Groups d4c89ce feat(managed): Use new data source for 'Managed Resources' config section efcceb3 feat(managed): add 'managedResources' data source 4ed015a feat(dataSources): widen + parameterize types, add default values 8c29cba Reactify titus launch configuration (spinnaker#7581) 5d89a04 feat(google): add gce scale-down controls (spinnaker#7570) f882544 feat(git/repo): add git/repo artifact support in kustomize bake manifest (spinnaker#7572)
sergiopena
pushed a commit
to sergiopena/deck
that referenced
this pull request
Jan 10, 2020
…est (spinnaker#7572) * feat(git/repo): add git/repo artifact support in kustomize bake manifest * Update app/scripts/modules/core/src/pipeline/config/stages/bakeManifest/kustomize/BakeKustomizeConfigForm.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com> * Update app/scripts/modules/core/src/pipeline/config/stages/bakeManifest/kustomize/BakeKustomizeConfigForm.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com> * Update app/scripts/modules/core/src/pipeline/config/triggers/artifacts/gitrepo/GitRepoArtifactEditor.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com>
sergiopena
pushed a commit
to sergiopena/deck
that referenced
this pull request
Jan 10, 2020
34a3b00 feat(managed): Update resource indicators to use new data source 7b33d2b feat(managed): Join managed data to infra data, add moniker to Security Groups d4c89ce feat(managed): Use new data source for 'Managed Resources' config section efcceb3 feat(managed): add 'managedResources' data source 4ed015a feat(dataSources): widen + parameterize types, add default values 8c29cba Reactify titus launch configuration (spinnaker#7581) 5d89a04 feat(google): add gce scale-down controls (spinnaker#7570) f882544 feat(git/repo): add git/repo artifact support in kustomize bake manifest (spinnaker#7572)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…est (spinnaker#7572) * feat(git/repo): add git/repo artifact support in kustomize bake manifest * Update app/scripts/modules/core/src/pipeline/config/stages/bakeManifest/kustomize/BakeKustomizeConfigForm.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com> * Update app/scripts/modules/core/src/pipeline/config/stages/bakeManifest/kustomize/BakeKustomizeConfigForm.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com> * Update app/scripts/modules/core/src/pipeline/config/triggers/artifacts/gitrepo/GitRepoArtifactEditor.tsx Co-Authored-By: Maggie Neterval <mneterval@google.com>
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
34a3b00 feat(managed): Update resource indicators to use new data source 7b33d2b feat(managed): Join managed data to infra data, add moniker to Security Groups d4c89ce feat(managed): Use new data source for 'Managed Resources' config section efcceb3 feat(managed): add 'managedResources' data source 4ed015a feat(dataSources): widen + parameterize types, add default values 8c29cba Reactify titus launch configuration (spinnaker#7581) 5d89a04 feat(google): add gce scale-down controls (spinnaker#7570) f882544 feat(git/repo): add git/repo artifact support in kustomize bake manifest (spinnaker#7572)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the git/repo artifact type when baking a manifest using kustomize. With this change, git/repo is the only supported artifact for kustomize.
Original PR adding git/repo artifact type: spinnaker/clouddriver#4049
Related PRs to this kustomize work: