feat(executions): Adding new ADMIN endpoint to import execution #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r spinnaker instance. Useful to get a execution into other envs for troubleshooting. Only imports executions with TERMINAL, SUCCEEDED or CANCELLED states.
orca-web/src/main/groovy/com/netflix/spinnaker/orca/controllers/AdminController.groovy
Show resolved
Hide resolved
|
Thanks for doing this, I think it would be useful and LGTM, but would like another opinion as to any side effects this could cause, @cfieber / @robzienert ? |
marchello2000
changed the title
ajordens
reviewed
Nov 25, 2019
| @ResponseStatus(HttpStatus.CREATED) | ||
| Map<String, String> createExecution(@RequestBody Execution execution) { | ||
|
|
||
| if (front50Service && !front50Service.get(execution.application)) { |
There was a problem hiding this comment.
I believe front50Service.get() will raise an exception if the application doesn't exist (vs. returning null).
I'm not sure we want to import executions for applications that don't exist?
|
|
||
| try { | ||
| executionRepository.retrieve(execution.type, execution.id) | ||
| log.warn('Execution found with id: []', execution.id) |
There was a problem hiding this comment.
warn seems like the wrong logging level? debug maybe? (or perhaps it's not even relevant given it's going to raise an exception immediately)
| log.warn('Execution found with id: []', execution.id) | ||
| throw new InvalidRequestException('Execution already exists with id: ' + execution.id) | ||
| } catch(ExecutionNotFoundException e) { | ||
| log.info('Execution not found .. can import it..') |
There was a problem hiding this comment.
This log message seems irrelevant and would get lost in the noise? There's no identifier included in the output.
This was referenced Dec 4, 2019
sergiopena
pushed a commit
to sergiopena/orca
that referenced
this pull request
Dec 13, 2019
…naker#3310) * feat(executions): Adding new endpoint to import execution from another spinnaker instance. Useful to get a execution into other envs for troubleshooting. Only imports executions with TERMINAL, SUCCEEDED or CANCELLED states. * Disallow if execution already exists and also add some info helper messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new Admin endpoint to import execution from another spinnaker instance.
Useful to get a execution into other envs for troubleshooting.
Only imports executions with TERMINAL, SUCCEEDED or CANCELLED states.