-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dependencies): Autobump keikoVersion #3653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
599a0a1
to
8948059
Compare
jonsie
pushed a commit
to jonsie/orca
that referenced
this pull request
May 5, 2020
Co-authored-by: root <root@bc779c563dc7>
mergify bot
pushed a commit
that referenced
this pull request
May 5, 2020
…nts, skipping Task for now (#3649) * feat(plugins): Use SpinnakerExtensionPoint where for extension points, skipping Task for now * fix(plugins): use latest kork version * chore(dependencies): Autobump keikoVersion (#3653) Co-authored-by: root <root@bc779c563dc7> * feat(queue): support for dynamic activation of the queue shovel (#3630) * feat(queue): support for dynamic action of the queue shovel This makes it possible to have a QueueShovel bean enabled by default, but not active. Once the `queue.shovel.active` flag becomes true, it will start actively shoveling messages for some time then stop and check again. * chore(queue-shovel): switch to a fixed rate direct execution Instead of spawning threads with a fixed delay. Also: - add a log message when the shovel becomes active - derive the work duration from the execution rate (i.e. strive to work for a slightly shorter duration than the scheduled rate) - make isActive() responsible for checking both the property and the activator status - only check the activator in `isActive` instead of in every invocation of `migrateSome` * Update orca-queue/src/main/kotlin/com/netflix/spinnaker/orca/q/QueueShovel.kt Co-Authored-By: Mark Vulfson <markvu@live.com> * fix(config): add missing SqlQueueShovelConfiguration Co-authored-by: Mark Vulfson <markvu@live.com> * fix(plugins): tests help you catch dumb mistakes * fix(plugins): Back out change ot Task and TaskResolver, need to spend time thinking about these orca unit test failures Co-authored-by: spinnakerbot <spinbot@spinnaker.io> Co-authored-by: root <root@bc779c563dc7> Co-authored-by: Daniel Reynaud <reynaud.daniel@gmail.com> Co-authored-by: Mark Vulfson <markvu@live.com>
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
Co-authored-by: root <root@bc779c563dc7>
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
…nts, skipping Task for now (spinnaker#3649) * feat(plugins): Use SpinnakerExtensionPoint where for extension points, skipping Task for now * fix(plugins): use latest kork version * chore(dependencies): Autobump keikoVersion (spinnaker#3653) Co-authored-by: root <root@bc779c563dc7> * feat(queue): support for dynamic activation of the queue shovel (spinnaker#3630) * feat(queue): support for dynamic action of the queue shovel This makes it possible to have a QueueShovel bean enabled by default, but not active. Once the `queue.shovel.active` flag becomes true, it will start actively shoveling messages for some time then stop and check again. * chore(queue-shovel): switch to a fixed rate direct execution Instead of spawning threads with a fixed delay. Also: - add a log message when the shovel becomes active - derive the work duration from the execution rate (i.e. strive to work for a slightly shorter duration than the scheduled rate) - make isActive() responsible for checking both the property and the activator status - only check the activator in `isActive` instead of in every invocation of `migrateSome` * Update orca-queue/src/main/kotlin/com/netflix/spinnaker/orca/q/QueueShovel.kt Co-Authored-By: Mark Vulfson <markvu@live.com> * fix(config): add missing SqlQueueShovelConfiguration Co-authored-by: Mark Vulfson <markvu@live.com> * fix(plugins): tests help you catch dumb mistakes * fix(plugins): Back out change ot Task and TaskResolver, need to spend time thinking about these orca unit test failures Co-authored-by: spinnakerbot <spinbot@spinnaker.io> Co-authored-by: root <root@bc779c563dc7> Co-authored-by: Daniel Reynaud <reynaud.daniel@gmail.com> Co-authored-by: Mark Vulfson <markvu@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.